mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kapil Arya <>
Subject Re: Review Request 66872: Updated FrameworkInfo comparator.
Date Thu, 10 May 2018 01:11:50 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated May 9, 2018, 9:11 p.m.)

Review request for mesos, Benjamin Mahler and Till Toenshoff.

Bugs: MESOS-7258

Repository: mesos

Description (updated)

The comparator is more strict and checks for all fields.  Also removed
some existing un-needed comparisons from test cases that were clashing
with the new implementation. This is because the previous
implementation's limited comparison (just `name` and `user` fields)
succeeded whereas it fails with the newer implementaion due to the
stricter/fuller nature.

Diffs (updated)

  include/mesos/type_utils.hpp 19ea81716496bcc0117a1b0ff157a0374f38bbfa 
  include/mesos/v1/mesos.hpp fda3eb42061f820869a2d8da939fccadc4e5ddfb 
  src/common/type_utils.cpp 33d63809b61a18e03ff745c88f024c71dd221ca2 
  src/tests/master_allocator_tests.cpp e1aef8a9625a805e7ad2dfad37bfeedee82f160d 
  src/v1/mesos.cpp 9b2df2dd798dff24a91a2604ab53c7fbb5ecfbcf 





Kapil Arya

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message