mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 66996: Removed the OpenSSL dependency for building gRPC in Mesos.
Date Wed, 09 May 2018 19:02:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66996/
-----------------------------------------------------------

(Updated May 9, 2018, 7:02 p.m.)


Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Jie Yu.


Changes
-------

Addressed Benjamin's comment.


Bugs: MESOS-8798
    https://issues.apache.org/jira/browse/MESOS-8798


Repository: mesos


Description
-------

When the SSL build feature is disabled, Mesos now builds
`libgrpc_unsecure` and `libgrpc++_unsecure` instead of `libgrpc` and
`libgrpc++`, so the SSL headers and libraries are no longer required.


Diffs (updated)
-----

  3rdparty/Makefile.am 8d9fa85dd65a94d91670d54dab36deea80d14996 
  configure.ac 429797c35b93a6df69ba0cb0fc28cb66a3171074 
  src/Makefile.am 7e91681e3b8b217f8b23fa5347e059640c62fc65 
  src/python/native_common/ext_modules.py.in 87387fd580c40b252fc82f98b5238b9b9120903a 


Diff: https://reviews.apache.org/r/66996/diff/3/

Changes: https://reviews.apache.org/r/66996/diff/2-3/


Testing
-------

This patch does not work standalone. Tests are done in the next patch.


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message