mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 67025: Fixed the link order for gRPC in CMake.
Date Wed, 09 May 2018 18:45:59 GMT


> On May 9, 2018, 10:35 a.m., Benjamin Bannier wrote:
> > 3rdparty/CMakeLists.txt
> > Line 1009 (original), 1009 (patched)
> > <https://reviews.apache.org/r/67025/diff/1/?file=2018306#file2018306line1009>
> >
> >     Why are we moving `libgrpc++` before `libgrpc` here in addition to moving `libgpr`
to the back?
> >     
> >     I see both the C++ and C libraries depend on `libgpr` so it should definitely
be on the back to allow correct static links; I see no dependencies between `libgprc++` and
`libgprc` though so we might as well stick to lexicographic order.

`libgrpc` is not gRPC's C wrapper. It's the core library. And despite that the current build
doesn't generate linkage between `libgrpc` and `libgrpc++`, the C++ wrappers do include the
core library headers, so it seems safer and more future-proof to me to keep this order. Dropping
this.


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67025/#review202747
-----------------------------------------------------------


On May 9, 2018, 2:28 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67025/
> -----------------------------------------------------------
> 
> (Updated May 9, 2018, 2:28 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed the link order for gRPC in CMake.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 0075c133ef60bfef06f4123c14cae8a5672440f5 
> 
> 
> Diff: https://reviews.apache.org/r/67025/diff/1/
> 
> 
> Testing
> -------
> 
> sudo ninja check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message