mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 67018: Removed unnecessary gRPC build flags in libprocess.
Date Wed, 09 May 2018 18:29:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67018/
-----------------------------------------------------------

(Updated May 9, 2018, 6:29 p.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Changes
-------

Addressed Benjamin's comment.


Bugs: MESOS-8798
    https://issues.apache.org/jira/browse/MESOS-8798


Repository: mesos


Description
-------

The `-Wno-deprecated-declarations` and `-Wno-unused-function` flags are
no longer required to build the bundled gRPC 1.10.0.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/Makefile.am 7fb77f8f29e00a276cfb0efc5324ac838c8b5176 


Diff: https://reviews.apache.org/r/67018/diff/2/

Changes: https://reviews.apache.org/r/67018/diff/1-2/


Testing
-------

Tests done later in chain.


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message