mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 67021: Windows: Enabled `ProtobufTest` suite.
Date Wed, 09 May 2018 18:02:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67021/#review202775
-----------------------------------------------------------



PASS: Mesos patch 67021 was successfully built and tested.

Reviews applied: `['67021']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67021

- Mesos Reviewbot Windows


On May 8, 2018, 4:41 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67021/
> -----------------------------------------------------------
> 
> (Updated May 8, 2018, 4:41 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and Radhika
Jandhyala.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> These tests just worked once added to the build. Also, out-of-date
> code was deleted from `systems_tests.cpp`, and a note added to the
> build file that it (and `signals_tests.cpp`) will be not be ported to
> Windows.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/tests/CMakeLists.txt 28674c9873b7bbccb6b990ec16b7e40a5bf4f9ec 
>   3rdparty/stout/tests/os/systems_tests.cpp a2a05ce28d11cdb97a511e5392a05522a45826c8

> 
> 
> Diff: https://reviews.apache.org/r/67021/diff/1/
> 
> 
> Testing
> -------
> 
> I just noticed that these weren't enabled when checking something else. Turned them on,
they passed. Will push when CI passes.
> 
> ```
> Note: Google Test filter = ProtobufTest.*-
> [==========] Running 12 tests from 1 test case.
> [----------] Global test environment set-up.
> [----------] 12 tests from ProtobufTest
> [ RUN      ] ProtobufTest.JSON
> [       OK ] ProtobufTest.JSON (17 ms)
> [ RUN      ] ProtobufTest.JSONArray
> [       OK ] ProtobufTest.JSONArray (1 ms)
> [ RUN      ] ProtobufTest.JsonLargeIntegers
> [       OK ] ProtobufTest.JsonLargeIntegers (2 ms)
> [ RUN      ] ProtobufTest.SimpleMessageEquals
> [       OK ] ProtobufTest.SimpleMessageEquals (0 ms)
> [ RUN      ] ProtobufTest.ParseJSONArray
> [       OK ] ProtobufTest.ParseJSONArray (1 ms)
> [ RUN      ] ProtobufTest.ParseJSONNull
> [       OK ] ProtobufTest.ParseJSONNull (0 ms)
> [ RUN      ] ProtobufTest.ParseJSONNestedError
> [       OK ] ProtobufTest.ParseJSONNestedError (0 ms)
> [ RUN      ] ProtobufTest.ParseJSONUnrecognizedEnum
> [       OK ] ProtobufTest.ParseJSONUnrecognizedEnum (1 ms)
> [ RUN      ] ProtobufTest.Jsonify
> [       OK ] ProtobufTest.Jsonify (1 ms)
> [ RUN      ] ProtobufTest.JsonifyArray
> [       OK ] ProtobufTest.JsonifyArray (0 ms)
> [ RUN      ] ProtobufTest.JsonifyLargeIntegers
> [       OK ] ProtobufTest.JsonifyLargeIntegers (1 ms)
> [ RUN      ] ProtobufTest.JsonifyMap
> [       OK ] ProtobufTest.JsonifyMap (6 ms)
> [----------] 12 tests from ProtobufTest (30 ms total)
> 
> [----------] Global test environment tear-down
> [==========] 12 tests from 1 test case ran. (31 ms total)
> [  PASSED  ] 12 tests.
> ```
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message