mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Review Request 67021: Windows: Enabled `ProtobufTest` suite.
Date Tue, 08 May 2018 23:41:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67021/
-----------------------------------------------------------

Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and Radhika Jandhyala.


Repository: mesos


Description
-------

These tests just worked once added to the build. Also, out-of-date
code was deleted from `systems_tests.cpp`, and a note added to the
build file that it (and `signals_tests.cpp`) will be not be ported to
Windows.


Diffs
-----

  3rdparty/stout/tests/CMakeLists.txt 28674c9873b7bbccb6b990ec16b7e40a5bf4f9ec 
  3rdparty/stout/tests/os/systems_tests.cpp a2a05ce28d11cdb97a511e5392a05522a45826c8 


Diff: https://reviews.apache.org/r/67021/diff/1/


Testing
-------

I just noticed that these weren't enabled when checking something else. Turned them on, they
passed. Will push when CI passes.


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message