mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Re: Review Request 66993: Removed unnecessary expectation on termination.
Date Tue, 08 May 2018 14:22:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66993/#review202635
-----------------------------------------------------------




src/tests/containerizer/docker_containerizer_tests.cpp
Line 644 (original), 644 (patched)
<https://reviews.apache.org/r/66993/#comment284567>

    We can add
    ```cpp
      Future<Nothing> executorTerminated =
        FUTURE_DISPATCH(_, &Slave::executorTerminated);
    ```
    here and wait for it before stopping the driver
    ```cpp
    AWAIT_READY(executorTerminated);
    ```
    WDYT?


- Andrei Budnik


On May 7, 2018, 10:25 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66993/
> -----------------------------------------------------------
> 
> (Updated May 7, 2018, 10:25 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and James Peach.
> 
> 
> Bugs: MESOS-8884
>     https://issues.apache.org/jira/browse/MESOS-8884
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test was flaky because termination could already happened when we
> set up the expectation. Given that we already verified task state, I do
> not see checking container termination explicitly is necessary, so
> removing the expectation should fix the flakiness.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp d834e531a550028cd57ac409c9312dd22138e8d5

> 
> 
> Diff: https://reviews.apache.org/r/66993/diff/1/
> 
> 
> Testing
> -------
> 
> GTEST_FILTER="DockerContainerizerTest.ROOT_DOCKER_MaxCompletionTime" ./bin/mesos-tests.sh
--gtest_repeat=100 --verbose
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message