mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Review Request 66997: Removed the OpenSSL dependency for building gRPC in libprocess.
Date Tue, 08 May 2018 03:25:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66997/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Jie Yu.


Bugs: MESOS-8798
    https://issues.apache.org/jira/browse/MESOS-8798


Repository: mesos


Description
-------

When the SSL build feature is disabled, libprocess now builds
`libgrpc_unsecure` and `libgrpc++_unsecure` instead of `libgrpc` and
`libgrpc++`, so the SSL headers and libraries are no longer required.

NOTE: gRPC v1.10 no longer needs `-Wno-deprecated-declarations` and
`-Wno-unused-function` when building with OpenSSL v1.1.


Diffs
-----

  3rdparty/libprocess/3rdparty/Makefile.am 7fb77f8f29e00a276cfb0efc5324ac838c8b5176 
  3rdparty/libprocess/Makefile.am 70edb2ec3ad8b222cd28064f1012c39c335c57a5 
  3rdparty/libprocess/configure.ac fd65d7062ee42eccf2a68d23d02e456d07da6513 


Diff: https://reviews.apache.org/r/66997/diff/1/


Testing
-------

sudo make check in Mesos build and libprocess standalone build, with openssl 1.0.2l and 1.1.0f.


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message