mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 66953: Windows: Fixed dup to properly copy the overlapped WindowsFD.
Date Mon, 07 May 2018 18:57:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66953/#review202570
-----------------------------------------------------------



This could/should be squashed into the prior commit. Reasoning: prior commit is broken without
it, it's logically the same change, and it's all still in stout.

- Andrew Schwartzmeyer


On May 4, 2018, 10:16 a.m., Akash Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66953/
> -----------------------------------------------------------
> 
> (Updated May 4, 2018, 10:16 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, John Kordich,
Joseph Wu, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-8670
>     https://issues.apache.org/jira/browse/MESOS-8670
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> After the previous commit,`os::dup` was not copying the overlapped
> field, so it has been updated to copy it.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/windows/dup.hpp af98054f1bd9c8e55c52b246fda8734e3ca96e21

> 
> 
> Diff: https://reviews.apache.org/r/66953/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message