mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 66952: Windows: Added overlapped field to WindowsFD.
Date Mon, 07 May 2018 18:54:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66952/#review202567
-----------------------------------------------------------


Fix it, then Ship it!




Just nits on comments.


3rdparty/stout/include/stout/os/windows/fd.hpp
Lines 78 (patched)
<https://reviews.apache.org/r/66952/#comment284379>

    `s/socket handles/sockets` just to not confuse with the `HANDLE` type above.



3rdparty/stout/include/stout/os/windows/fd.hpp
Lines 80 (patched)
<https://reviews.apache.org/r/66952/#comment284380>

    `s/a/an`



3rdparty/stout/include/stout/os/windows/fd.hpp
Lines 170 (patched)
<https://reviews.apache.org/r/66952/#comment284381>

    Nit: clang-format on this for style



3rdparty/stout/include/stout/os/windows/open.hpp
Lines 48 (patched)
<https://reviews.apache.org/r/66952/#comment284383>

    `s/open/opens`


- Andrew Schwartzmeyer


On May 4, 2018, 10:15 a.m., Akash Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66952/
> -----------------------------------------------------------
> 
> (Updated May 4, 2018, 10:15 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, John Kordich,
Joseph Wu, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-8670 and MESOS-8674
>     https://issues.apache.org/jira/browse/MESOS-8670
>     https://issues.apache.org/jira/browse/MESOS-8674
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added an field to WindowsFD for functions that need to know if a
> Windows file is opened in overlapped mode, such as `os::read`, since
> Windows doesn't provide a Win32 API for it.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/windows/fd.hpp bab16e869e69c214e18de584d1615311316e001a

>   3rdparty/stout/include/stout/os/windows/open.hpp 701dcec7c4c1162d38d8f25596af29ed3b32691d

> 
> 
> Diff: https://reviews.apache.org/r/66952/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message