mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Radhika Jandhyala via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 66954: Windows: Added overlapped aware io.hpp file for `os::read/write`.
Date Mon, 07 May 2018 18:52:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66954/#review202566
-----------------------------------------------------------




3rdparty/stout/include/stout/os/windows/io.hpp
Lines 61 (patched)
<https://reviews.apache.org/r/66954/#comment284377>

    The in params can be const here



3rdparty/stout/include/stout/os/windows/io.hpp
Lines 89 (patched)
<https://reviews.apache.org/r/66954/#comment284378>

    Param can be const along with data and size


- Radhika Jandhyala


On May 4, 2018, 5:21 p.m., Akash Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66954/
> -----------------------------------------------------------
> 
> (Updated May 4, 2018, 5:21 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, John Kordich,
Joseph Wu, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-8670
>     https://issues.apache.org/jira/browse/MESOS-8670
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a helper file for io, because `os::read/write` need to work on
> both non-overlapped and overlapped files, so the logic has gotten
> more complicated. The new file, `io.hpp`, has all the shared logic.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/Makefile.am f2e60224d9c729497bbcfffbec989c4f355d8f85 
>   3rdparty/stout/include/stout/os/windows/io.hpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/66954/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message