mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 66635: Introduced wrapper for access to cgroups system access.
Date Mon, 07 May 2018 18:13:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66635/#review202562
-----------------------------------------------------------



PASS: Mesos patch 66635 was successfully built and tested.

Reviews applied: `['66634', '66987', '66635']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66635

- Mesos Reviewbot Windows


On May 7, 2018, 8:56 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66635/
> -----------------------------------------------------------
> 
> (Updated May 7, 2018, 8:56 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-8786
>     https://issues.apache.org/jira/browse/MESOS-8786
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Different cgroups subsystems are modelled as actors. In this patch we
> introduce wrapper classes which `dispatch` to the processes. This
> removes e.g., races from mixing naked and `dispatch`'ed method calls.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 5763c9880728f02e44116fd50e62b592a8ef69b6

>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 4431ce13d28035b0c5c037b2848ae03aeaf65562

>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 65c1e47a569f320b63b54e5f4fc1da374d02ee0d

>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 9afa02b207e6272836e5a36d69fb48f1f4d02150

> 
> 
> Diff: https://reviews.apache.org/r/66635/diff/3/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message