mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Review Request 66983: Added an option to show if filtering is due to framework decline.
Date Mon, 07 May 2018 06:15:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66983/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler, Kapil Arya, Till Toenshoff, and Vinod Kone.


Repository: mesos


Description
-------

Currently there could be various reasons that resources are
filtered. It may or may not be linked to framework decline.

This patch adds an `declined` field to the filter to distinguish
filters created due to framework decline from the ones created due
to other reasons such as agent update.

Currently `declined` is set to true in filters created in three
cases: framework `DECLINE` calls, framework `ACCEPT` calls with
filters explicitly set and offer timeouts.

In addition, added an option boolean to `isFiltered()` check so
that callers would know if the filter is linked to earlier framework
decline.


Diffs
-----

  src/master/allocator/mesos/hierarchical.hpp 955ae3e6a9e3c790fb260311ec4b4ef725a826d3 
  src/master/allocator/mesos/hierarchical.cpp 1000968be6a2935a4cac571414d7f06d7df7acf0 


Diff: https://reviews.apache.org/r/66983/diff/1/


Testing
-------

make check


Thanks,

Meng Zhu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message