mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 66978: Disabled debug mode for libevent.
Date Mon, 07 May 2018 04:03:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66978/#review202535
-----------------------------------------------------------



PASS: Mesos patch 66978 was successfully built and tested.

Reviews applied: `['66977', '66978']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66978

- Mesos Reviewbot Windows


On May 7, 2018, 2:05 a.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66978/
> -----------------------------------------------------------
> 
> (Updated May 7, 2018, 2:05 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Joseph Wu.
> 
> 
> Bugs: MESOS-8885
>     https://issues.apache.org/jira/browse/MESOS-8885
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Debug mode enables additional tracking in libevent to check for common
> errors. It is recommended to "only enable debug mode when actually
> debugging your program" because "tracking which events are initialized
> requires that Libevent use extra memory and CPU".
> 
> http://www.wangafu.net/~nickm/libevent-book/Ref1_libsetup.html
> 
> We could consider introducing libevent flags in order to be able to
> toggle this behavior with an environment variable since it appears
> that libevent does not provide one. However, since I don't believe
> these assertions have been of value, we can just remove the debug mode
> for now.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/libevent.cpp eb3998c2043c7c8be2a6ea1458bb3e1824f6df1e 
> 
> 
> Diff: https://reviews.apache.org/r/66978/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message