-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66931/#review202435
-----------------------------------------------------------
PASS: Mesos patch 66931 was successfully built and tested.
Reviews applied: `['66931']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66931
- Mesos Reviewbot Windows
On May 4, 2018, 10:37 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66931/
> -----------------------------------------------------------
>
> (Updated May 4, 2018, 10:37 a.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
>
>
> Bugs: MESOS-8874
> https://issues.apache.org/jira/browse/MESOS-8874
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We previously did not make ensure that after the simulated agent
> failover in
> `ResourceProviderManagerHttpApiTest.ResubscribeResourceProvider` the
> mock resource provider created as part of the test did not reconnect
> to the restarted agent (as opposed to the newly initialized resource
> provider). This lead to unmet test expectations.
>
> With this patch we now explicitly tear down the mock resource provider
> after we have detected that the agent went away to prevent the race.
>
>
> Diffs
> -----
>
> src/tests/resource_provider_manager_tests.cpp e8ca377fd0a927b99fdaf6a8ee0139025a41298e
>
>
> Diff: https://reviews.apache.org/r/66931/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
> Ran the test repeatedly under high system load without triggering the issue again with
this patch.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
|