mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 66931: Fixed a race in resource provider resubscription test.
Date Fri, 04 May 2018 10:37:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66931/
-----------------------------------------------------------

(Updated May 4, 2018, 12:37 p.m.)


Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.


Changes
-------

Addressed comments.


Bugs: MESOS-8874
    https://issues.apache.org/jira/browse/MESOS-8874


Repository: mesos


Description
-------

We previously did not make ensure that after the simulated agent
failover in
`ResourceProviderManagerHttpApiTest.ResubscribeResourceProvider` the
mock resource provider created as part of the test did not reconnect
to the restarted agent (as opposed to the newly initialized resource
provider). This lead to unmet test expectations.

With this patch we now explicitly tear down the mock resource provider
after we have detected that the agent went away to prevent the race.


Diffs (updated)
-----

  src/tests/resource_provider_manager_tests.cpp e8ca377fd0a927b99fdaf6a8ee0139025a41298e 


Diff: https://reviews.apache.org/r/66931/diff/2/

Changes: https://reviews.apache.org/r/66931/diff/1-2/


Testing
-------

`make check`

Ran the test repeatedly under high system load without triggering the issue again with this
patch.


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message