mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 66908: Correctly reconciled dropped operation after agent failover.
Date Fri, 04 May 2018 10:37:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66908/
-----------------------------------------------------------

(Updated May 4, 2018, 12:37 p.m.)


Review request for mesos, Gaston Kleiman and Greg Mann.


Changes
-------

Addressed comments.


Bugs: MESOS-8870
    https://issues.apache.org/jira/browse/MESOS-8870


Repository: mesos


Description
-------

When the master receives an `UpdateSlaveMessage` after agent failover
it previously did not correctly detect dropped operations (operations
known to the master, but unknown to the agent) and did not trigger
reconciliation for such operations.

This patch fixes the handler in the master so that such dropped
operations are reconciled.


Diffs (updated)
-----

  src/master/master.cpp 7a2f69c1fe2508e16c2685cd3490d5b1f59d6ac4 
  src/tests/master_slave_reconciliation_tests.cpp 6bb4263323bcfd191c8e3c1ccba10a240e9ddd83



Diff: https://reviews.apache.org/r/66908/diff/2/

Changes: https://reviews.apache.org/r/66908/diff/1-2/


Testing
-------

`make check`

The test in this patch fails without the corresponding master change, but succeeds with it
applied.


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message