mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Re: Review Request 66532: Added test for authorization actions for `RESIZE_VOLUME`.
Date Thu, 03 May 2018 22:06:53 GMT


> On May 2, 2018, 11:51 a.m., Chun-Hung Hsiao wrote:
> > src/tests/persistent_volume_tests.cpp
> > Lines 1289 (patched)
> > <https://reviews.apache.org/r/66532/diff/8/?file=2015784#file2015784line1289>
> >
> >     I don't think we need this but it doesn't hurt. I'll leave it up to you to decide
if you want to keep this. Please feel free to drop it if you prefer keeping it.
> >     
> >     This is more of a personal preference ;) I prefer always introducing synchronizations
for a reason but some others prefer making tests as deterministic as possible.

I think I prefer keeping it for now.


- Zhitao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66532/#review202300
-----------------------------------------------------------


On May 1, 2018, 3:55 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66532/
> -----------------------------------------------------------
> 
> (Updated May 1, 2018, 3:55 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Greg Mann.
> 
> 
> Bugs: MESOS-8748
>     https://issues.apache.org/jira/browse/MESOS-8748
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test for authorization actions for `RESIZE_VOLUME`.
> 
> 
> Diffs
> -----
> 
>   src/tests/authorization_tests.cpp a76ad18a54ec232e6d6c92ec6a45b445a83f174c 
>   src/tests/persistent_volume_tests.cpp 4edf781711d9efdb994114aeb6289b6af750b87a 
> 
> 
> Diff: https://reviews.apache.org/r/66532/diff/8/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message