mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 66920: Improved tests for resizing persistent volumes.
Date Thu, 03 May 2018 16:33:18 GMT


> On May 3, 2018, 3:51 p.m., Zhitao Li wrote:
> > src/tests/persistent_volume_tests.cpp
> > Lines 604 (patched)
> > <https://reviews.apache.org/r/66920/diff/2/?file=2016203#file2016203line607>
> >
> >     Technically we only tested that persistent volume and its data can still be
accessed.
> >     
> >     I do not know a reliable and efficient way to test the volume size actually
changed after resizing.
> >     
> >     Maybe clarify the comment?

Hmm I thought the slave will check the consumed task resources but apparently it only checks
checkpointed resources:
https://github.com/apache/mesos/blob/master/src/slave/slave.cpp#L2743
For `GROW_VOLUME`, this check is sufficient to ensure that the volume is resized.
However, for `SHRINK_VOLUME`, I'll make a dynamic reservation on the disk resources first
so when the volume is shrunk, the freed space is considered as a checkpointed resource:
https://github.com/apache/mesos/blob/master/src/common/resources_utils.cpp#L30


> On May 3, 2018, 3:51 p.m., Zhitao Li wrote:
> > src/tests/persistent_volume_tests.cpp
> > Line 751 (original), 807 (patched)
> > <https://reviews.apache.org/r/66920/diff/2/?file=2016203#file2016203line813>
> >
> >     ```
> >     This test verifies that launching any task depending either origial or grown
volume of a `GROW_VOLUME` call in the same `acceptOffers` will be dropped...
> >     ```

Thanks. I'll say the following:
```
// This test verifies that any task to launch after a `GROW_VOLUME` in the same
// `ACCEPT` call is dropped if the task consumes the original or grown volume
```


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66920/#review202355
-----------------------------------------------------------


On May 3, 2018, 4:54 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66920/
> -----------------------------------------------------------
> 
> (Updated May 3, 2018, 4:54 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Zhitao Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Now the `GrowVolume` and `ShrinkVolume` tests launch tasks after
> resizing the volumes to ensure that the operations take effect on
> agents. The `NonSpeculativeGrowAndLaunch` and
> `NonSpeculativeShrinkAndLaunch` tests launch an additional task to
> verify that the original volume consumed by the operations cannot be
> used by subsequent tasks.
> 
> This patch also adjusted when the clock is resumed so schedulers will
> not receive unexpected offers.
> 
> 
> Diffs
> -----
> 
>   src/tests/persistent_volume_tests.cpp 4edf781711d9efdb994114aeb6289b6af750b87a 
> 
> 
> Diff: https://reviews.apache.org/r/66920/diff/2/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message