mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 66227: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operator API.
Date Wed, 02 May 2018 23:20:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66227/#review202329
-----------------------------------------------------------




src/tests/api_tests.cpp
Lines 3685-3687 (patched)
<https://reviews.apache.org/r/66227/#comment284088>

    This test actually works on Windows :)
    ```
    PS C:\Users\chhsiao\src\mesos\build-grpc> src/mesos-tests.exe --gtest_filter="*Grow*:*Shrink*"
    ...
    [==========] Running 4 tests from 1 test case.
    [----------] Global test environment set-up.
    [----------] 4 tests from ContentType/MasterAPITest
    [ RUN      ] ContentType/MasterAPITest.GrowVolume/0
    [       OK ] ContentType/MasterAPITest.GrowVolume/0 (264 ms)
    [ RUN      ] ContentType/MasterAPITest.GrowVolume/1
    [       OK ] ContentType/MasterAPITest.GrowVolume/1 (267 ms)
    [ RUN      ] ContentType/MasterAPITest.ShrinkVolume/0
    [       OK ] ContentType/MasterAPITest.ShrinkVolume/0 (193 ms)
    [ RUN      ] ContentType/MasterAPITest.ShrinkVolume/1
    [       OK ] ContentType/MasterAPITest.ShrinkVolume/1 (232 ms)
    [----------] 4 tests from ContentType/MasterAPITest (999 ms total)
    
    [----------] Global test environment tear-down
    [==========] 4 tests from 1 test case ran. (1406 ms total)
    [  PASSED  ] 4 tests.
    ```



src/tests/api_tests.cpp
Lines 3798-3800 (patched)
<https://reviews.apache.org/r/66227/#comment284089>

    Ditto.


- Chun-Hung Hsiao


On May 2, 2018, 5:28 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66227/
> -----------------------------------------------------------
> 
> (Updated May 2, 2018, 5:28 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann.
> 
> 
> Bugs: MESOS-8747
>     https://issues.apache.org/jira/browse/MESOS-8747
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operator API.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp dd8e221d8fd1b2a241505345337897e4ee4a6347 
> 
> 
> Diff: https://reviews.apache.org/r/66227/diff/8/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message