mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Review Request 66912: Resolved the `realpath` of the sandbox directory in tests.
Date Wed, 02 May 2018 18:29:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66912/
-----------------------------------------------------------

Review request for mesos, Chun-Hung Hsiao, Joseph Wu, and Jan Schlicht.


Bugs: MESOS-8868
    https://issues.apache.org/jira/browse/MESOS-8868


Repository: mesos


Description
-------

This fixes test failures on systems (like macOS) where `/tmp` is a
symlink. One such scenario is a test which makes a file in the
sandbox, then makes a symlink to the file, and finally compares the
realpath of the symlink to the file. If the part of the path of the
original file in the sandbox is a symlink, this will cause the test to
fail. The fact that the sandbox path is not a fully resolved file name
is confusing. By instead getting the `realpath` of the sandbox during
setup, we can fix the current test failures, and avoid future ones.


Diffs
-----

  3rdparty/stout/include/stout/tests/utils.hpp bfbaa01514214c15f7d62742d37bfd8fa4514974 


Diff: https://reviews.apache.org/r/66912/diff/1/


Testing
-------

stout-tests and libprocess-tests on a MacBook (mesos-tests is still building)


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message