mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Re: Review Request 66858: Added tests for validation of `GrowVolume` and `ShrinkVolume`.
Date Wed, 02 May 2018 17:26:23 GMT


> On May 1, 2018, 7:18 p.m., Chun-Hung Hsiao wrote:
> > src/tests/master_validation_tests.cpp
> > Lines 1657 (patched)
> > <https://reviews.apache.org/r/66858/diff/2/?file=2015777#file2015777line1657>
> >
> >     Hmm... we don't have this check when validating `GrowVolume` because we are
counting on the fact that adding anything disk to a MOUNT disk will result in two resources.
But I guess for the validation test maybe it's a good idea to also test this for `GrowVolume`.
What do you think?

MOUNT would actually pass here in current implementation. As we discussed, I think it may
be a good idea to explicitly validate this then test it out.

Let me know what you think.


- Zhitao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66858/#review202251
-----------------------------------------------------------


On May 2, 2018, 10:24 a.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66858/
> -----------------------------------------------------------
> 
> (Updated May 2, 2018, 10:24 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Greg Mann.
> 
> 
> Bugs: MESOS-4945
>     https://issues.apache.org/jira/browse/MESOS-4945
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests for validation of `GrowVolume` and `ShrinkVolume`.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_validation_tests.cpp a5229610a81dfac9d358597135b63ee51de86659 
> 
> 
> Diff: https://reviews.apache.org/r/66858/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message