mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 66220: Added tests for `GROW_VOLUME` and `SHRINK_VOLUME` operations.
Date Wed, 02 May 2018 16:41:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66220/#review202285
-----------------------------------------------------------



Just leaving the things we discussed here for a record. The issues can be addressed in a follow-up
patch after 1.6 RC if you don't have time.


src/tests/persistent_volume_tests.cpp
Lines 580 (patched)
<https://reviews.apache.org/r/66220/#comment284059>

    How about doing these checks in a task so we could validate that a task could actually
use the grown volume on the agent? This can be added in a follow-up patch.



src/tests/persistent_volume_tests.cpp
Lines 721 (patched)
<https://reviews.apache.org/r/66220/#comment284060>

    Ditto.


- Chun-Hung Hsiao


On May 1, 2018, 10:44 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66220/
> -----------------------------------------------------------
> 
> (Updated May 1, 2018, 10:44 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann.
> 
> 
> Bugs: MESOS-4965
>     https://issues.apache.org/jira/browse/MESOS-4965
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests for `GROW_VOLUME` and `SHRINK_VOLUME` operations.
> 
> 
> Diffs
> -----
> 
>   src/tests/persistent_volume_tests.cpp 4edf781711d9efdb994114aeb6289b6af750b87a 
> 
> 
> Diff: https://reviews.apache.org/r/66220/diff/10/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message