mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 66903: Fixed incorrect enum value comparisons.
Date Wed, 02 May 2018 10:36:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66903/#review202266
-----------------------------------------------------------



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['66903']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66903

Relevant logs:

- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66903/logs/mesos-tests-stdout.log):

```
[----------] 9 tests from Endpoint/SlaveEndpointTest (1075 ms total)

[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN      ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[       OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (31 ms)
[ RUN      ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[       OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (37 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (70 ms total)

[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN      ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[       OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (812 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (836 ms total)

[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN      ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[       OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (732 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (757 ms total)

[----------] Global test environment tear-down
[==========] 970 tests from 95 test cases ran. (469175 ms total)
[  PASSED  ] 968 tests.
[  FAILED  ] 2 tests, listed below:
[  FAILED  ] ContentType/ResourceProviderManagerHttpApiTest.ResubscribeResourceProvider/0,
where GetParam() = application/x-protobuf
[  FAILED  ] ContentType/ResourceProviderManagerHttpApiTest.ResubscribeResourceProvider/1,
where GetParam() = application/json

 2 FAILED TESTS
  YOU HAVE 216 DISABLED TESTS

```

- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66903/logs/mesos-tests-stderr.log):

```
I0502 10:35:57.002964  2308 master.cpp:10547] Updating the state of task 563d06be-fa44-484f-8efd-2b236b58fe75
of framework 2a81b3a7-ed4b-43a3-84cc-262234ad9473-0000 (latest state: TASK_KILLED, status
update state: TASK_KILLED)
I0502 10:35:57.002964 12724 slave.cpp:3935] Shutting down framework 2a81b3a7-ed4b-43a3-84cc-262234ad9473-0000
I0502 10:35:57.003938 12724 slave.cpp:6644] Shutting down executor '56I0502 10:35:56.849915
 6916 exec.cpp:162] Version: 1.6.0
I0502 10:35:56.875952 13676 exec.cpp:236] Executor registered on agent 2a81b3a7-ed4b-43a3-84cc-262234ad9473-S0
I0502 10:35:56.878955  3488 executor.cpp:177] Received SUBSCRIBED event
I0502 10:35:56.883934  3488 executor.cpp:181] Subscribed executor on winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0502 10:35:56.883934  3488 executor.cpp:177] Received LAUNCH event
I0502 10:35:56.888932  3488 executor.cpp:649] Starting task 563d06be-fa44-484f-8efd-2b236b58fe75
I0502 10:35:56.966929  3488 executor.cpp:484] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe
launch <POSSIBLY-SENSITIVE-DATA>'
I0502 10:35:56.978940  3488 executor.cpp:662] Forked command at 3552
I0502 10:35:57.005937 12008 exec.cpp:445] Executor asked to shutdown
I0502 10:35:57.006938 10224 executor.cpp:177] Received SHUTDOWN event
I0502 10:35:57.006938 10224 executor.cpp:759] Shutting down
I0502 10:35:57.006938 10224 executor.cpp:869] Sending SIGTERM to process tree at pid 33d06be-fa44-484f-8efd-2b236b58fe75'
of framework 2a81b3a7-ed4b-43a3-84cc-262234ad9473-0000 at executor(1)@10.3.1.8:57878
I0502 10:35:57.005937 12724 slave.cpp:929] Agent terminating
W0502 10:35:57.005937 12724 slave.cpp:3931] Ignoring shutdown framework 2a81b3a7-ed4b-43a3-84cc-262234ad9473-0000
because it is terminating
I0502 10:35:57.005937  2308 master.cpp:10646] Removing task 563d06be-fa44-484f-8efd-2b236b58fe75
with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated:
*):[31000-32000] of framework 2a81b3a7-ed4b-43a3-84cc-262234ad9473-0000 on agent 2a81b3a7-ed4b-43a3-84cc-262234ad9473-S0
at slave(438)@10.3.1.8:57857 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0502 10:35:57.008921  6352 master.cpp:1296] Agent 2a81b3a7-ed4b-43a3-84cc-262234ad9473-S0
at slave(438)@10.3.1.8:57857 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
disconnected
I0502 10:35:57.008921  6352 master.cpp:3296] Disconnecting agent 2a81b3a7-ed4b-43a3-84cc-262234ad9473-S0
at slave(438)@10.3.1.8:57857 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0502 10:35:57.009938  6352 master.cpp:3315] Deactivating agent 2a81b3a7-ed4b-43a3-84cc-262234ad9473-S0
at slave(438)@10.3.1.8:57857 (winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0502 10:35:57.010937 12912 hierarchical.cpp:344] Removed framework 2a81b3a7-ed4b-43a3-84cc-262234ad9473-0000
I0502 10:35:57.010937 12912 hierarchical.cpp:766] Agent 2a81b3a7-ed4b-43a3-84cc-262234ad9473-S0
deactivated
I0502 10:35:57.010937 14140 containerizer.cpp:2378] Destroying container c9166a1c-369b-4ef6-a5aa-bfad16267294
in RUNNING state
I0502 10:35:57.011932 14140 containerizer.cpp:2992] Transitioning the state of container c9166a1c-369b-4ef6-a5aa-bfad16267294
from RUNNING to DESTROYING
I0502 10:35:57.011932 14140 launcher.cpp:156] Asked to destroy container c9166a1c-369b-4ef6-a5aa-bfad16267294
I0502 10:35:57.050925 13500 containerizer.cpp:2831] Container c9166a1c-369b-4ef6-a5aa-bfad16267294
has exited
I0502 10:35:57.084931  3776 master.cpp:1138] Master terminating
I0502 10:35:57.086938 12724 hierarchical.cpp:609] Removed agent 2a81b3a7-ed4b-43a3-84cc-262234ad9473-S0
I0502 10:35:57.462978 10732 process.cpp:940] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On May 2, 2018, 9:36 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66903/
> -----------------------------------------------------------
> 
> (Updated May 2, 2018, 9:36 a.m.)
> 
> 
> Review request for mesos and James Peach.
> 
> 
> Bugs: MESOS-8865
>     https://issues.apache.org/jira/browse/MESOS-8865
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Due to ADL the enum values found originally found in this function where
> from the v0 namespace while the value we compared to was from the v1
> namespace. While this might work should the enum values in v0 and v1 map
> to the same enum values, it does not seem to have been the intention and
> is brittle.
> 
> This patch uses slightly longer names to refer to the enum values which
> do not map onto symbols found via ADL.
> 
> 
> Diffs
> -----
> 
>   src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp ea8d54ff198a5529d61a41bcb6e5806378761091

> 
> 
> Diff: https://reviews.apache.org/r/66903/diff/1/
> 
> 
> Testing
> -------
> 
> `make check` with clang. While before clang emitted diagnostics for the lines touched
here, no such diagnostics are emitted anymore with this patch.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message