mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Review Request 66903: Fixed incorrect enum value comparisons.
Date Wed, 02 May 2018 09:36:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66903/
-----------------------------------------------------------

Review request for mesos and James Peach.


Bugs: MESOS-8865
    https://issues.apache.org/jira/browse/MESOS-8865


Repository: mesos


Description
-------

Due to ADL the enum values found originally found in this function where
from the v0 namespace while the value we compared to was from the v1
namespace. While this might work should the enum values in v0 and v1 map
to the same enum values, it does not seem to have been the intention and
is brittle.

This patch uses slightly longer names to refer to the enum values which
do not map onto symbols found via ADL.


Diffs
-----

  src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp ea8d54ff198a5529d61a41bcb6e5806378761091



Diff: https://reviews.apache.org/r/66903/diff/1/


Testing
-------

`make check` with clang. While before clang emitted diagnostics for the lines touched here,
no such diagnostics are emitted anymore with this patch.


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message