mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Megha Sharma <mshar...@apple.com>
Subject Re: Review Request 66644: Remove unknown unreachable tasks when agent reregisters.
Date Wed, 02 May 2018 05:18:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66644/
-----------------------------------------------------------

(Updated May 2, 2018, 5:18 a.m.)


Review request for mesos and Jiang Yan Xu.


Bugs: 8750
    https://issues.apache.org/jira/browse/8750


Repository: mesos


Description (updated)
-------

A RunTask messsage could get dropped for an agent while its
disconnected from the master and when such an agent goes unreachable
then this dropped task message gets added to the unreachable tasks.
When the agent reregisters, the master sends status updates for the
tasks that the agent reported when re-registering and these tasks are
also removed from the unreachableTasks on the framework but since the
agent doesn't know about the dropped task so it doesn't get removed
from the unreachableTasks leading to a check failure when
this inconsistency is detected during framework removal.


Diffs (updated)
-----

  src/master/master.hpp 0d9620dd0c232dc1df83477e838eeb7313bf8828 
  src/master/master.cpp 767ad8cfe142b47ef07172bcb2a4fb49fc3e833a 
  src/tests/partition_tests.cpp 9138e5c745cf354a3573e1ab0b251d46702833cc 


Diff: https://reviews.apache.org/r/66644/diff/5/

Changes: https://reviews.apache.org/r/66644/diff/4-5/


Testing
-------

make check


Thanks,

Megha Sharma


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message