mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Megha Sharma <mshar...@apple.com>
Subject Re: Review Request 66644: Remove unknown unreachable tasks when agent reregisters.
Date Wed, 02 May 2018 05:15:40 GMT


> On May 1, 2018, 8:50 p.m., Jiang Yan Xu wrote:
> > src/tests/partition_tests.cpp
> > Lines 171 (patched)
> > <https://reviews.apache.org/r/66644/diff/3-4/?file=2012149#file2012149line171>
> >
> >     This seems to be exceeded the 80 character limit.

For some reason the pre-commit hook didn't complain for this.


> On May 1, 2018, 8:50 p.m., Jiang Yan Xu wrote:
> > src/tests/partition_tests.cpp
> > Lines 47 (patched)
> > <https://reviews.apache.org/r/66644/diff/4/?file=2012299#file2012299line47>
> >
> >     It doesn't look like this is used?

Aah yes that's right.


- Megha


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66644/#review202215
-----------------------------------------------------------


On April 25, 2018, 3:46 p.m., Megha Sharma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66644/
> -----------------------------------------------------------
> 
> (Updated April 25, 2018, 3:46 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: 8750
>     https://issues.apache.org/jira/browse/8750
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> A RunTask messsage could get dropped for an agent while it's
> disconnected from the master and when such an agent goes unreachable
> then this dropped task gets added to the unreachable tasks.
> When the agent reregisters, tasks reported by it are removed from the unreachableTasks
bookkeeping on the master but since the
> agent doesn't know about the dropped task so it doesn't get removed
> from the unreachableTasks leading to a master check failure when
> this inconsistency is detected during framework removal.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 0d9620dd0c232dc1df83477e838eeb7313bf8828 
>   src/master/master.cpp 767ad8cfe142b47ef07172bcb2a4fb49fc3e833a 
>   src/tests/partition_tests.cpp 9138e5c745cf354a3573e1ab0b251d46702833cc 
> 
> 
> Diff: https://reviews.apache.org/r/66644/diff/4/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Megha Sharma
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message