mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 66885: Removed unnecessary `get()` accessors.
Date Tue, 01 May 2018 23:26:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66885/#review202240
-----------------------------------------------------------



Patch looks great!

Reviews applied: [66885]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On May 1, 2018, 9:33 a.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66885/
> -----------------------------------------------------------
> 
> (Updated May 1, 2018, 9:33 a.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In many cases, containers that have a `get()` accessor also have
> a `->` operator that can be used to directly access their help
> object. Replace `.get().` with `->` for improved consistency and
> readability.
> 
> 
> Diffs
> -----
> 
>   src/cli/resolve.cpp fe62f9fc569b77f6e5fb101ac7e2515a9f14d08a 
>   src/java/jni/org_apache_mesos_Log.cpp e5e632c0255c372e2ed5622940523bd1381b7b9c 
>   src/linux/routing/diagnosis/diagnosis.cpp 3e80a29427569180039719ded11194a0afc814b5

>   src/linux/routing/filter/icmp.cpp 68a1c3486e3fceb7110769240fbca97e3325ef31 
>   src/linux/routing/filter/internal.hpp b22a818517e98fecf5ddf96fd0fa2ed95ecde15d 
>   src/linux/routing/filter/ip.cpp dd8cec7de680731ff626bf928c2f85eea2ef2b7a 
>   src/linux/routing/link/internal.hpp 12064076c017cb71f403625f209e463dbd49d82f 
>   src/linux/routing/link/link.cpp 5388a3d4af11083f08b79e25d439cfe33252f1b8 
>   src/linux/routing/link/veth.cpp e12af9fd9d0874dd006b0ce1ade373bba259aa78 
>   src/linux/routing/queueing/internal.hpp 9fe522ee017c86af8c7b2e518cd0957af08750e4 
>   src/linux/routing/route.cpp ba39eac3aa37244c5ca79f50423423e219b81450 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 96e1a2b4133171e7a204e5d234c28ed81913261c

>   src/slave/containerizer/mesos/isolators/windows/cpu.cpp 104e35d2cba072c08be1e0ec6074c1bd43464c87

>   src/slave/containerizer/mesos/isolators/windows/mem.cpp eb6c93e5657db3758325de9192e164da5935ec60

>   src/slave/containerizer/mesos/isolators/xfs/disk.cpp db11f9a095dec0edcdded42d1d41ebcbad68db19

>   src/slave/containerizer/mesos/isolators/xfs/utils.cpp cc14254f3711b81a0f93e9bef77bf81d651718b9

> 
> 
> Diff: https://reviews.apache.org/r/66885/diff/2/
> 
> 
> Testing
> -------
> 
> make check (Fedora 27)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message