mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 66790: Windows: Ported the rest of the `SubprocessTest` suite.
Date Tue, 01 May 2018 22:42:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66790/
-----------------------------------------------------------

(Updated May 1, 2018, 3:42 p.m.)


Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, and Joseph Wu.


Changes
-------

Enabled Flags test.


Bugs: MESOS-8833
    https://issues.apache.org/jira/browse/MESOS-8833


Repository: mesos


Description
-------

These tests mostly "just worked" on Windows, with only minor changes,
such as converting POSIX shell-script to Batch or PowerShell, and
expecting Windows line-endings and quoting semantics.


Diffs (updated)
-----

  3rdparty/libprocess/src/tests/subprocess_tests.cpp be99bd6a88b2abcabed8d4d16763c2e29f38eb14



Diff: https://reviews.apache.org/r/66790/diff/3/

Changes: https://reviews.apache.org/r/66790/diff/2-3/


Testing (updated)
-------

~~13~~ ~~14~~ 15 more tests running on Windows :)


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message