mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 66790: Windows: Ported the rest of the `SubprocessTest` suite.
Date Tue, 01 May 2018 22:09:47 GMT


> On May 1, 2018, 2:39 p.m., Joseph Wu wrote:
> > 3rdparty/libprocess/src/tests/subprocess_tests.cpp
> > Lines 651-652 (original), 697-698 (patched)
> > <https://reviews.apache.org/r/66790/diff/2/?file=2014811#file2014811line705>
> >
> >     What's wrong with this test?  (You might want to expand the TODO a bit)

I don't know what's wrong with it! I've naively tried just using `cmd.exe` and `{cmd.exe,
cmd.exe, echo}` but some of the assertions fail. I was punting it, but am now debugging it.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66790/#review202220
-----------------------------------------------------------


On April 30, 2018, 2:11 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66790/
> -----------------------------------------------------------
> 
> (Updated April 30, 2018, 2:11 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, and Joseph Wu.
> 
> 
> Bugs: MESOS-8833
>     https://issues.apache.org/jira/browse/MESOS-8833
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> These tests mostly "just worked" on Windows, with only minor changes,
> such as converting POSIX shell-script to Batch or PowerShell, and
> expecting Windows line-endings and quoting semantics.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/subprocess_tests.cpp be99bd6a88b2abcabed8d4d16763c2e29f38eb14

> 
> 
> Diff: https://reviews.apache.org/r/66790/diff/2/
> 
> 
> Testing
> -------
> 
> ~~13~~ 14 more tests running on Windows :)
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message