mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 66834: Windows: Specialized `flags::parse<int_fd>`.
Date Tue, 01 May 2018 22:08:27 GMT


> On May 1, 2018, 2:48 p.m., Joseph Wu wrote:
> > 3rdparty/stout/include/stout/flags/parse.hpp
> > Lines 197-200 (patched)
> > <https://reviews.apache.org/r/66834/diff/1/?file=2013396#file2013396line197>
> >
> >     There should be a check for exactly 2 tokens here.  Instead of using the `maxTokens`
parameter of `strings::split`.
> >     
> >     The existing code would crash pretty easily.

> The existing code would crash pretty easily.

The `operator>>` on `WindowsFD` would have to be manually changed to cause a crash here,
but I hear you. I'll split and `CHECK`.


> On May 1, 2018, 2:48 p.m., Joseph Wu wrote:
> > 3rdparty/stout/include/stout/flags/parse.hpp
> > Lines 201 (patched)
> > <https://reviews.apache.org/r/66834/diff/1/?file=2013396#file2013396line201>
> >
> >     I must be missing something... Where are `parse<HANDLE>` and `parse<SOCKET>`
defined?

It's the generic template above; uses an `istringstream` which handles `void*` and `unisgned
__int64` in the STL.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66834/#review202226
-----------------------------------------------------------


On April 26, 2018, 9:22 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66834/
> -----------------------------------------------------------
> 
> (Updated April 26, 2018, 9:22 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Specialized `flags::parse<int_fd>`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/flags/parse.hpp eb6d5272ffefcfe4fe7b97f9c7c7084893269b64

> 
> 
> Diff: https://reviews.apache.org/r/66834/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message