mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 66836: Fixed `mesos-tcp-connect` to use `net::socket`.
Date Tue, 01 May 2018 21:53:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66836/#review202230
-----------------------------------------------------------


Ship it!




Ship It!

- Joseph Wu


On April 26, 2018, 9:22 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66836/
> -----------------------------------------------------------
> 
> (Updated April 26, 2018, 9:22 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Use the stout wrapper instead of `::socket` so we have built-in error
> checking (and don't have to worry about types).
> 
> 
> Diffs
> -----
> 
>   src/checks/tcp_connect.cpp f5df732415b1e3ac02e9624909d822febe60fe8c 
> 
> 
> Diff: https://reviews.apache.org/r/66836/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message