mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 66532: Added test for authorization actions for `RESIZE_VOLUME`.
Date Tue, 01 May 2018 17:44:06 GMT


> On May 1, 2018, 4:05 a.m., Chun-Hung Hsiao wrote:
> > src/tests/persistent_volume_tests.cpp
> > Lines 1464 (patched)
> > <https://reviews.apache.org/r/66532/diff/6/?file=2014384#file2014384line1464>
> >
> >     No need to resume the clock here, as the fixture teardown will resume it. However,
I'm not sure if you need to resume the clock before stopping and joining `driver2`.
> 
> Zhitao Li wrote:
>     I think enough tests explicitly resume the clock, so I'd like to keep it unless you
have issue with it.

That's fine but I was wondering if we should move this before `driver2.stop()`, as we do in
other tests.


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66532/#review202170
-----------------------------------------------------------


On April 27, 2018, 8:08 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66532/
> -----------------------------------------------------------
> 
> (Updated April 27, 2018, 8:08 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Greg Mann.
> 
> 
> Bugs: MESOS-8748
>     https://issues.apache.org/jira/browse/MESOS-8748
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test for authorization actions for `RESIZE_VOLUME`.
> 
> 
> Diffs
> -----
> 
>   src/tests/authorization_tests.cpp a76ad18a54ec232e6d6c92ec6a45b445a83f174c 
>   src/tests/persistent_volume_tests.cpp 4edf781711d9efdb994114aeb6289b6af750b87a 
> 
> 
> Diff: https://reviews.apache.org/r/66532/diff/6/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message