mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Re: Review Request 53267: Added a PullGauge to track active subscribers.
Date Tue, 01 May 2018 15:54:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53267/
-----------------------------------------------------------

(Updated May 1, 2018, 8:54 a.m.)


Review request for mesos, Anand Mazumdar, Jason Lai, and James Peach.


Changes
-------

Rebase and use PullGauge.


Summary (updated)
-----------------

Added a PullGauge to track active subscribers.


Bugs: MESOS-6499
    https://issues.apache.org/jira/browse/MESOS-6499


Repository: mesos


Description (updated)
-------

Added a PullGauge to track active subscribers.


Diffs (updated)
-----

  src/master/master.hpp c30cf082d9ddf2e5dd97e0d887d6d07d8e03cbd4 
  src/master/master.cpp c723a291ed8d219ced4492bc905ac6b52683ae47 
  src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b 
  src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45 


Diff: https://reviews.apache.org/r/53267/diff/4/

Changes: https://reviews.apache.org/r/53267/diff/3-4/


Testing
-------

Ran this on master with a client keeps subscribing and disconnecting. Observes that gauge
gets updated and new log line is printed.


Thanks,

Zhitao Li


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message