From reviews-return-76828-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Apr 27 23:21:21 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4E38B18A56 for ; Fri, 27 Apr 2018 23:21:21 +0000 (UTC) Received: (qmail 31499 invoked by uid 500); 27 Apr 2018 23:21:21 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 31463 invoked by uid 500); 27 Apr 2018 23:21:21 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 31446 invoked by uid 99); 27 Apr 2018 23:21:20 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Apr 2018 23:21:20 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 013D3C005C; Fri, 27 Apr 2018 23:21:20 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.142 X-Spam-Level: ** X-Spam-Status: No, score=2.142 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_REPLYTO_END_DIGIT=0.25, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 4V9MbfO2XnsF; Fri, 27 Apr 2018 23:21:19 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id BA61A5F3CC; Fri, 27 Apr 2018 23:21:18 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 4A4A4E024A; Fri, 27 Apr 2018 23:21:18 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 135DAC4045E; Fri, 27 Apr 2018 23:21:17 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4928669737544350636==" MIME-Version: 1.0 Subject: Re: Review Request 66828: Introduced a push-based gauge metric. From: Gilbert Song To: Greg Mann , Vinod Kone , Gaston Kleiman , Gilbert Song , James Peach Cc: Benjamin Mahler , mesos Date: Fri, 27 Apr 2018 23:21:17 -0000 Message-ID: <20180427232117.63760.44622@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated In-Reply-To: <20180426215413.9618.66282@reviews-vm2.apache.org> X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/66828/ X-Sender: Gilbert Song X-ReviewBoard-ShipIt: 1 References: <20180426215413.9618.66282@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: 3rdparty/libprocess/include/process/metrics/push_gauge.hpp X-ReviewBoard-ShipIt-Only: 1 Reply-To: Gilbert Song X-ReviewRequest-Repository: mesos Sender: Gilbert Song --===============4928669737544350636== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66828/#review202095 ----------------------------------------------------------- Ship it! Ship It! - Gilbert Song On April 26, 2018, 2:54 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66828/ > ----------------------------------------------------------- > > (Updated April 26, 2018, 2:54 p.m.) > > > Review request for mesos, Gaston Kleiman, Gilbert Song, Greg Mann, James Peach, and Vinod Kone. > > > Bugs: MESOS-8851 > https://issues.apache.org/jira/browse/MESOS-8851 > > > Repository: mesos > > > Description > ------- > > A push-based gauge differs from a pull-based gauge in that the > client is responsible for pushing the latest value into the gauge > whenever it changes. This can be challenging in some cases as it > requires the client to have a good handle on when the gauge value > changes (rather than just computing the current value when asked). > > It is highly recommended to use push-based gauges if possible as > they provide significant performance benefits over pull-based > gauges. Pull-based gauge suffer from delays getting processed on > the event queue of a `Process`, as well as incur computation cost > on the `Process` each time the metrics are collected. Push-based > gauges, on the other hand, incur no cost to the owning `Process` > when metrics are collected, and instead incur a trivial cost when > the `Process` pushes new values in. > > > Diffs > ----- > > 3rdparty/libprocess/include/Makefile.am cd2c3bc62df8de5b50ec2fa830b3e2634ba11e28 > 3rdparty/libprocess/include/process/metrics/push_gauge.hpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/66828/diff/1/ > > > Testing > ------- > > Test added in the subsequent patch. > > > Thanks, > > Benjamin Mahler > > --===============4928669737544350636==--