From reviews-return-76827-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Apr 27 23:15:12 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 88F0D18A22 for ; Fri, 27 Apr 2018 23:15:12 +0000 (UTC) Received: (qmail 18655 invoked by uid 500); 27 Apr 2018 23:15:12 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 18620 invoked by uid 500); 27 Apr 2018 23:15:12 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 18605 invoked by uid 99); 27 Apr 2018 23:15:11 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Apr 2018 23:15:11 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 5AAA6C1C69; Fri, 27 Apr 2018 23:15:11 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.651 X-Spam-Level: ** X-Spam-Status: No, score=2.651 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_REPLYTO_END_DIGIT=0.25, HEADER_FROM_DIFFERENT_DOMAINS=0.25, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id za4vUiSsao17; Fri, 27 Apr 2018 23:15:10 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 2600A5F188; Fri, 27 Apr 2018 23:15:09 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6280EE024A; Fri, 27 Apr 2018 23:15:08 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 24157C4045E; Fri, 27 Apr 2018 23:15:08 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7942230481674007106==" MIME-Version: 1.0 Subject: Re: Review Request 66831: Renamed Gauge to PullGauge and documented differences to PushGauge. From: Gilbert Song To: Greg Mann , Vinod Kone , Gaston Kleiman , Gilbert Song , James Peach Cc: Benjamin Mahler , mesos Date: Fri, 27 Apr 2018 23:15:07 -0000 Message-ID: <20180427231507.63759.56016@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Gilbert Song X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/66831/ X-Sender: Gilbert Song References: <20180426215417.9617.59993@reviews-vm2.apache.org> In-Reply-To: <20180426215417.9617.59993@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: 3rdparty/libprocess/include/process/metrics/pull_gauge.hpp X-ReviewBoard-Diff-For: 3rdparty/libprocess/include/process/metrics/gauge.hpp Reply-To: Gilbert Song X-ReviewRequest-Repository: mesos --===============7942230481674007106== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66831/#review202094 ----------------------------------------------------------- 3rdparty/libprocess/include/Makefile.am Line 50 (original), 49-50 (patched) Switch order - Gilbert Song On April 26, 2018, 2:54 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66831/ > ----------------------------------------------------------- > > (Updated April 26, 2018, 2:54 p.m.) > > > Review request for mesos, Gaston Kleiman, Gilbert Song, Greg Mann, James Peach, and Vinod Kone. > > > Bugs: MESOS-8851 > https://issues.apache.org/jira/browse/MESOS-8851 > > > Repository: mesos > > > Description > ------- > > Given `PushGauge`, it makes sense to explicitly distinguish the two > gauge types and document the the caveats of `PullGauge`. > > > Diffs > ----- > > 3rdparty/libprocess/include/Makefile.am cd2c3bc62df8de5b50ec2fa830b3e2634ba11e28 > 3rdparty/libprocess/include/process/metrics/gauge.hpp 474f8e80b0128ae8d742a022733019351710ef48 > 3rdparty/libprocess/include/process/metrics/metric.hpp 21f162d5b7d9e56dc3289d65b6d86deb4c2fa721 > 3rdparty/libprocess/include/process/metrics/pull_gauge.hpp PRE-CREATION > 3rdparty/libprocess/include/process/system.hpp 6bd815daa27c069e25461e73fcc7327c4645e9fc > 3rdparty/libprocess/src/tests/metrics_tests.cpp f2bd99bd289d728932b3206958902a99e436eaa7 > 3rdparty/libprocess/src/tests/system_tests.cpp 17f288146c81b37a900b3df7d1797ba7bdfd00ca > > > Diff: https://reviews.apache.org/r/66831/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Mahler > > --===============7942230481674007106==--