From reviews-return-76529-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Apr 20 22:53:46 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E9AD518032 for ; Fri, 20 Apr 2018 22:53:46 +0000 (UTC) Received: (qmail 4442 invoked by uid 500); 20 Apr 2018 22:53:46 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 4409 invoked by uid 500); 20 Apr 2018 22:53:46 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 4390 invoked by uid 99); 20 Apr 2018 22:53:46 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Apr 2018 22:53:46 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id B54A41807B1; Fri, 20 Apr 2018 22:53:45 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.189 X-Spam-Level: * X-Spam-Status: No, score=1.189 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.249, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id dHT10r1_dzVD; Fri, 20 Apr 2018 22:53:44 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 202B45F188; Fri, 20 Apr 2018 22:53:44 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7E501E00C6; Fri, 20 Apr 2018 22:53:43 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 51BEEC40659; Fri, 20 Apr 2018 22:53:43 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8794480012617385022==" MIME-Version: 1.0 Subject: Re: Review Request 66464: Implemented operation status reconciliation. From: Gaston Kleiman To: Greg Mann Cc: Gaston Kleiman , mesos Date: Fri, 20 Apr 2018 22:53:43 -0000 Message-ID: <20180420225343.25941.27207@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Gaston Kleiman X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/66464/ X-Sender: Gaston Kleiman References: <20180418213601.3189.27809@reviews-vm2.apache.org> In-Reply-To: <20180418213601.3189.27809@reviews-vm2.apache.org> Reply-To: Gaston Kleiman X-ReviewRequest-Repository: mesos --===============8794480012617385022== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66464/ ----------------------------------------------------------- (Updated April 20, 2018, 3:53 p.m.) Review request for mesos and Greg Mann. Changes ------- Addressed feedback + rebased. Bugs: MESOS-8191 https://issues.apache.org/jira/browse/MESOS-8191 Repository: mesos Description ------- Implemented operation status reconciliation. Diffs (updated) ----- include/mesos/v1/scheduler/scheduler.proto 25ebcfcb07cb4fb928dcfdc242bb6509c9080491 src/master/http.cpp 34c9023906eca94965acc994f20e888c1f47b962 src/master/master.hpp 0d9620dd0c232dc1df83477e838eeb7313bf8828 src/master/master.cpp 767ad8cfe142b47ef07172bcb2a4fb49fc3e833a src/messages/messages.proto 556801d9ece3ada6d8e3cec51882ad50c27e24b2 Diff: https://reviews.apache.org/r/66464/diff/6/ Changes: https://reviews.apache.org/r/66464/diff/5-6/ Testing ------- `sudo bin/mesos-tests` on GNU/Linux https://reviews.apache.org/r/66468/ adds new tests. Thanks, Gaston Kleiman --===============8794480012617385022==--