From reviews-return-76528-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Apr 20 22:53:26 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id ED60A18030 for ; Fri, 20 Apr 2018 22:53:26 +0000 (UTC) Received: (qmail 4066 invoked by uid 500); 20 Apr 2018 22:53:26 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 4030 invoked by uid 500); 20 Apr 2018 22:53:26 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 4019 invoked by uid 99); 20 Apr 2018 22:53:26 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Apr 2018 22:53:26 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id B40ADC0148; Fri, 20 Apr 2018 22:53:25 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.942 X-Spam-Level: X-Spam-Status: No, score=0.942 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id SaNDnkIDXKwl; Fri, 20 Apr 2018 22:53:23 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 26ED95F5B3; Fri, 20 Apr 2018 22:53:23 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id BF738E00C6; Fri, 20 Apr 2018 22:53:22 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 92EFFC40659; Fri, 20 Apr 2018 22:53:22 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4273058270361905496==" MIME-Version: 1.0 Subject: Re: Review Request 66463: Added a master metric for operations reconciliation messages. From: Gaston Kleiman To: Greg Mann Cc: Gaston Kleiman , mesos Date: Fri, 20 Apr 2018 22:53:22 -0000 Message-ID: <20180420225322.25941.21250@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Gaston Kleiman X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/66463/ X-Sender: Gaston Kleiman References: <20180404235934.64153.15051@reviews-vm2.apache.org> In-Reply-To: <20180404235934.64153.15051@reviews-vm2.apache.org> Reply-To: Gaston Kleiman X-ReviewRequest-Repository: mesos --===============4273058270361905496== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66463/ ----------------------------------------------------------- (Updated April 20, 2018, 3:53 p.m.) Review request for mesos and Greg Mann. Changes ------- Rebased. Bugs: MESOS-8191 https://issues.apache.org/jira/browse/MESOS-8191 Repository: mesos Description ------- Added a master metric for operations reconciliation messages. Diffs (updated) ----- docs/monitoring.md 12e2103eb041e3e1b99bddafafcf4c615205fb0c docs/operator-http-api.md 10dcac83fa70da5760a5c231665d7498cc168622 src/master/metrics.hpp 5699c64bac19cb735a4c72f9a067b1338c2ac3c2 src/master/metrics.cpp 894c04173d218ffd891d203254035fe4756cc8bb src/tests/master_tests.cpp be7a3cc6126d2fe7c56c49b3da5f6f4bf29657f5 Diff: https://reviews.apache.org/r/66463/diff/2/ Changes: https://reviews.apache.org/r/66463/diff/1-2/ Testing ------- `sudo bin/mesos-tests` on GNU/Linux Thanks, Gaston Kleiman --===============4273058270361905496==--