From reviews-return-76523-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Apr 20 22:47:23 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 138B418FFA for ; Fri, 20 Apr 2018 22:47:23 +0000 (UTC) Received: (qmail 92704 invoked by uid 500); 20 Apr 2018 22:47:23 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 92664 invoked by uid 500); 20 Apr 2018 22:47:22 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 92643 invoked by uid 99); 20 Apr 2018 22:47:22 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Apr 2018 22:47:22 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id D89EC1A0043; Fri, 20 Apr 2018 22:47:21 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.94 X-Spam-Level: X-Spam-Status: No, score=0.94 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.25, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id ysAkqVUmVwuf; Fri, 20 Apr 2018 22:47:21 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 3AAEE5F1C6; Fri, 20 Apr 2018 22:47:20 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 923A6E00C6; Fri, 20 Apr 2018 22:47:19 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 659BEC40659; Fri, 20 Apr 2018 22:47:19 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8294270634656703800==" MIME-Version: 1.0 Subject: Re: Review Request 66458: Fixed handling of operations in `master::recoverFramework()`. From: Gaston Kleiman To: Greg Mann Cc: Gaston Kleiman , mesos Date: Fri, 20 Apr 2018 22:47:19 -0000 Message-ID: <20180420224719.25941.13139@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Gaston Kleiman X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/66458/ X-Sender: Gaston Kleiman References: <20180404234726.64153.11527@reviews-vm2.apache.org> In-Reply-To: <20180404234726.64153.11527@reviews-vm2.apache.org> Reply-To: Gaston Kleiman X-ReviewRequest-Repository: mesos --===============8294270634656703800== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66458/ ----------------------------------------------------------- (Updated April 20, 2018, 3:47 p.m.) Review request for mesos and Greg Mann. Changes ------- Rebased. Repository: mesos Description ------- `Master::recoverFramework()` only recovers operations affecting agent default resources. This patch makes it also recover operations affecting resources managed by resource providers. It also fixes a bug in which not just the corresponding operations, but all the ones affecting agent default resources will be added to the framework. Diffs (updated) ----- src/master/master.cpp 767ad8cfe142b47ef07172bcb2a4fb49fc3e833a Diff: https://reviews.apache.org/r/66458/diff/2/ Changes: https://reviews.apache.org/r/66458/diff/1-2/ Testing ------- `sudo bin/mesos-tests` on GNU/Linux Thanks, Gaston Kleiman --===============8294270634656703800==--