From reviews-return-76282-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Apr 17 23:14:52 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2D82718F36 for ; Tue, 17 Apr 2018 23:14:52 +0000 (UTC) Received: (qmail 76327 invoked by uid 500); 17 Apr 2018 23:14:52 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 76295 invoked by uid 500); 17 Apr 2018 23:14:52 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 76280 invoked by uid 99); 17 Apr 2018 23:14:51 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Apr 2018 23:14:51 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id DB9001A0343; Tue, 17 Apr 2018 23:14:50 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.19 X-Spam-Level: * X-Spam-Status: No, score=1.19 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.25, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id Pc43uONYaDvj; Tue, 17 Apr 2018 23:14:49 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id E277E5F188; Tue, 17 Apr 2018 23:14:48 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 41725E0186; Tue, 17 Apr 2018 23:14:48 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id BBF41C40223; Tue, 17 Apr 2018 23:14:47 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6859325998058978682==" MIME-Version: 1.0 Subject: Re: Review Request 66531: Added new authorization for `UpdateVolume`. From: Greg Mann To: Chun-Hung Hsiao , Greg Mann Cc: Zhitao Li , mesos Date: Tue, 17 Apr 2018 23:14:47 -0000 Message-ID: <20180417231447.15549.59842@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Greg Mann X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/66531/ X-Sender: Greg Mann References: <20180410192404.29299.10338@reviews-vm2.apache.org> In-Reply-To: <20180410192404.29299.10338@reviews-vm2.apache.org> Reply-To: Greg Mann X-ReviewRequest-Repository: mesos --===============6859325998058978682== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66531/#review201357 ----------------------------------------------------------- src/master/master.hpp Lines 877 (patched) s/on a volume/of a volume/ src/master/master.cpp Lines 4924-4925 (original), 4980-4981 (patched) You need to finish implementing authorization here, and below for SHRINK_VOLUME. - Greg Mann On April 10, 2018, 7:24 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66531/ > ----------------------------------------------------------- > > (Updated April 10, 2018, 7:24 p.m.) > > > Review request for mesos, Chun-Hung Hsiao and Greg Mann. > > > Bugs: MESOS-8748 > https://issues.apache.org/jira/browse/MESOS-8748 > > > Repository: mesos > > > Description > ------- > > The new authorization action is modelled after `CreateVolume`, and will > be shared by both `GROW_VOLUME` and `SHRINK_VOLUME` operations and > corresponding operator APIs. > > > Diffs > ----- > > include/mesos/authorizer/acls.proto 8ef33210644e7d2924b402a3158b1b38c1fdb464 > include/mesos/authorizer/authorizer.proto 1508c01130013d74ed2b2574a2428f38e3d2c064 > src/authorizer/local/authorizer.cpp c098ba9ded1b29a2e079cf09ab80b61f6fa4af05 > src/master/master.hpp 0d9620dd0c232dc1df83477e838eeb7313bf8828 > src/master/master.cpp f7da675e8fe96159e5335c9e83b65b67ed90eda8 > > > Diff: https://reviews.apache.org/r/66531/diff/1/ > > > Testing > ------- > > Manually created ACL and verified that untrusted principals will not allow to grow/shrink volumes. > Also created unit test in next patch. > > > Thanks, > > Zhitao Li > > --===============6859325998058978682==--