From reviews-return-76280-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Apr 17 22:52:52 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D4AD118E5E for ; Tue, 17 Apr 2018 22:52:52 +0000 (UTC) Received: (qmail 22165 invoked by uid 500); 17 Apr 2018 22:52:52 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 22127 invoked by uid 500); 17 Apr 2018 22:52:52 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 22115 invoked by uid 99); 17 Apr 2018 22:52:52 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Apr 2018 22:52:52 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 86C35C792E; Tue, 17 Apr 2018 22:52:51 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.95 X-Spam-Level: X-Spam-Status: No, score=0.95 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.25, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id o1kjcUcrLhaW; Tue, 17 Apr 2018 22:52:50 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id B6EE45F485; Tue, 17 Apr 2018 22:52:49 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 091BFE0186; Tue, 17 Apr 2018 22:52:49 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 7F439C40223; Tue, 17 Apr 2018 22:52:48 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4992444899199690692==" MIME-Version: 1.0 Subject: Re: Review Request 66220: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operations. From: Gaston Kleiman To: Chun-Hung Hsiao , Gaston Kleiman , Greg Mann Cc: Zhitao Li , mesos Date: Tue, 17 Apr 2018 22:52:47 -0000 Message-ID: <20180417225247.60021.37225@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Gaston Kleiman X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/66220/ X-Sender: Gaston Kleiman References: <20180411211916.12093.34641@reviews-vm2.apache.org> In-Reply-To: <20180411211916.12093.34641@reviews-vm2.apache.org> Reply-To: Gaston Kleiman X-ReviewRequest-Repository: mesos --===============4992444899199690692== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66220/#review201355 ----------------------------------------------------------- src/tests/persistent_volume_tests.cpp Lines 474-475 (patched) I see that Benjamin recently added this line and the corresponding `AWAIT_READY` to many tests. However I don't think it is necessary here; I'll check with Benjamin to see if we can also remove it from other tests in which it is not necessary. src/tests/persistent_volume_tests.cpp Lines 502 (patched) Nit: `Offer offer = offersBeforeCreate->at(0);` If this test is split into smaller ones, then you can also probable make `offer` a const ref. - Gaston Kleiman On April 11, 2018, 2:19 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66220/ > ----------------------------------------------------------- > > (Updated April 11, 2018, 2:19 p.m.) > > > Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann. > > > Bugs: MESOS-4965 > https://issues.apache.org/jira/browse/MESOS-4965 > > > Repository: mesos > > > Description > ------- > > Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operations. > > > Diffs > ----- > > src/tests/persistent_volume_tests.cpp 4edf781711d9efdb994114aeb6289b6af750b87a > > > Diff: https://reviews.apache.org/r/66220/diff/4/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > > --===============4992444899199690692==--