From reviews-return-76204-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Apr 16 20:37:02 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C283B10164 for ; Mon, 16 Apr 2018 20:37:02 +0000 (UTC) Received: (qmail 64781 invoked by uid 500); 16 Apr 2018 20:37:02 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 64750 invoked by uid 500); 16 Apr 2018 20:37:02 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 64737 invoked by uid 99); 16 Apr 2018 20:37:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Apr 2018 20:37:01 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 8D52E1A0261; Mon, 16 Apr 2018 20:37:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.94 X-Spam-Level: X-Spam-Status: No, score=0.94 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 2xJD2JZxA_st; Mon, 16 Apr 2018 20:37:00 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 5F32D5F2C3; Mon, 16 Apr 2018 20:37:00 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E59E2E0309; Mon, 16 Apr 2018 20:36:59 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id B53A3C4015B; Mon, 16 Apr 2018 20:36:59 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6432201735190759794==" MIME-Version: 1.0 Subject: Re: Review Request 53267: Added a gauge to track active subscribers. From: James Peach To: Anand Mazumdar , James Peach , Jason Lai Cc: Zhitao Li , mesos Date: Mon, 16 Apr 2018 20:36:59 -0000 Message-ID: <20180416203659.5209.57131@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: James Peach X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/53267/ X-Sender: James Peach References: <20180412213324.14489.47284@reviews-vm2.apache.org> In-Reply-To: <20180412213324.14489.47284@reviews-vm2.apache.org> Reply-To: James Peach X-ReviewRequest-Repository: mesos --===============6432201735190759794== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53267/#review201256 ----------------------------------------------------------- Please document the new metric in `monitoring.md`. src/master/master.hpp Lines 2144 (patched) Nit. This should be in `master.cpp` for consistency with the other gauges. - James Peach On April 12, 2018, 9:33 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53267/ > ----------------------------------------------------------- > > (Updated April 12, 2018, 9:33 p.m.) > > > Review request for mesos, Anand Mazumdar, Jason Lai, and James Peach. > > > Bugs: MESOS-6499 > https://issues.apache.org/jira/browse/MESOS-6499 > > > Repository: mesos > > > Description > ------- > > Added a gauge to track active subscribers. > > > Diffs > ----- > > src/master/master.hpp 0d9620dd0c232dc1df83477e838eeb7313bf8828 > src/master/metrics.hpp 5699c64bac19cb735a4c72f9a067b1338c2ac3c2 > src/master/metrics.cpp 894c04173d218ffd891d203254035fe4756cc8bb > > > Diff: https://reviews.apache.org/r/53267/diff/2/ > > > Testing > ------- > > Ran this on master with a client keeps subscribing and disconnecting. Observes that gauge gets updated and new log line is printed. > > > Thanks, > > Zhitao Li > > --===============6432201735190759794==--