From reviews-return-76183-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Apr 16 16:58:14 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9A16A18764 for ; Mon, 16 Apr 2018 16:58:14 +0000 (UTC) Received: (qmail 45403 invoked by uid 500); 16 Apr 2018 16:58:14 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 45372 invoked by uid 500); 16 Apr 2018 16:58:14 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 45357 invoked by uid 99); 16 Apr 2018 16:58:13 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Apr 2018 16:58:13 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id EAE261A1BFC; Mon, 16 Apr 2018 16:58:12 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.94 X-Spam-Level: X-Spam-Status: No, score=0.94 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.25, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id EfrSi_7SfT-x; Mon, 16 Apr 2018 16:58:11 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id BFB295FB94; Mon, 16 Apr 2018 16:58:10 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 0697CE03A0; Mon, 16 Apr 2018 16:58:10 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id D0E48C412E6; Mon, 16 Apr 2018 16:58:09 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0393482401693416653==" MIME-Version: 1.0 Subject: Re: Review Request 66637: Added a `createDockerInfo` helper API in Docker containerizer tests. From: Gaston Kleiman To: Zhitao Li , Andrei Budnik , Gaston Kleiman , Greg Mann Cc: James Peach , mesos Date: Mon, 16 Apr 2018 16:58:09 -0000 Message-ID: <20180416165809.5209.37452@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Gaston Kleiman X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/66637/ X-Sender: Gaston Kleiman References: <20180416165207.5209.14576@reviews-vm2.apache.org> In-Reply-To: <20180416165207.5209.14576@reviews-vm2.apache.org> Reply-To: Gaston Kleiman X-ReviewRequest-Repository: mesos --===============0393482401693416653== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66637/#review201225 ----------------------------------------------------------- src/tests/containerizer/docker_containerizer_tests.cpp Lines 107-111 (patched) Nit: I'd do: ``` ContainerInfo::DockerInfo* dockerInfo = containerInfo.mutable_docker(); dockerInfo->set_image(imageName); return containerInfo; ``` src/tests/containerizer/docker_containerizer_tests.cpp Line 378 (original) The default networking is `HOST`, so this line shouldn't be removed. - Gaston Kleiman On April 16, 2018, 9:52 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66637/ > ----------------------------------------------------------- > > (Updated April 16, 2018, 9:52 a.m.) > > > Review request for mesos, Andrei Budnik, Gaston Kleiman, Greg Mann, and Zhitao Li. > > > Repository: mesos > > > Description > ------- > > The Docker containerizer tests all create a Docker `ContainerInfo`. > We can reduce the amount of copy/paste boilerplate by adding a > simple helper function to create a `ContainerInfo` with a Docker > image. > > > Diffs > ----- > > src/tests/containerizer/docker_containerizer_tests.cpp 847258daadf3c37d9071151616b18fc79d850ce8 > > > Diff: https://reviews.apache.org/r/66637/diff/1/ > > > Testing > ------- > > sudo make check (Fedora 27) > > > Thanks, > > James Peach > > --===============0393482401693416653==--