From reviews-return-76145-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Sat Apr 14 00:25:05 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 80A5E18ED5 for ; Sat, 14 Apr 2018 00:25:05 +0000 (UTC) Received: (qmail 46889 invoked by uid 500); 14 Apr 2018 00:25:05 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 46854 invoked by uid 500); 14 Apr 2018 00:25:05 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 46839 invoked by uid 99); 14 Apr 2018 00:25:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 14 Apr 2018 00:25:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 495641A168E; Sat, 14 Apr 2018 00:25:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.94 X-Spam-Level: X-Spam-Status: No, score=0.94 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.25, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 4uZFn_seqMLP; Sat, 14 Apr 2018 00:25:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 2F6975F3E3; Sat, 14 Apr 2018 00:25:02 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id CF39BE0BC2; Sat, 14 Apr 2018 00:25:00 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id A36A2C407A0; Sat, 14 Apr 2018 00:25:00 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4274933653875002507==" MIME-Version: 1.0 Subject: Re: Review Request 66615: Adopted `createTask` helper API in Docker containerizer tests. From: Gaston Kleiman To: Zhitao Li , Andrei Budnik , Gaston Kleiman , Greg Mann Cc: James Peach , mesos Date: Sat, 14 Apr 2018 00:25:00 -0000 Message-ID: <20180414002500.63171.34699@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Gaston Kleiman X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/66615/ X-Sender: Gaston Kleiman References: <20180413235745.63171.55865@reviews-vm2.apache.org> In-Reply-To: <20180413235745.63171.55865@reviews-vm2.apache.org> Reply-To: Gaston Kleiman X-ReviewRequest-Repository: mesos --===============4274933653875002507== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66615/#review201146 ----------------------------------------------------------- Thanks for the cleanup! I think we could get rid of quite some boilerplate with a helper that creates a `ContainerInfo::DockerInfo`. src/tests/containerizer/docker_containerizer_tests.cpp Line 265 (original), 260 (patched) Nit: I'd add an empty line above this one. Here and in the other tests. - Gaston Kleiman On April 13, 2018, 4:57 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66615/ > ----------------------------------------------------------- > > (Updated April 13, 2018, 4:57 p.m.) > > > Review request for mesos, Andrei Budnik, Gaston Kleiman, Greg Mann, and Zhitao Li. > > > Repository: mesos > > > Description > ------- > > The Docker containerizer tests were manually creating the `TaskInfo` > for the tasks they wanted to launch. We can remove some of that > boilerplate by adopting the `createTask` helper. > > > Diffs > ----- > > src/tests/containerizer/docker_containerizer_tests.cpp 847258daadf3c37d9071151616b18fc79d850ce8 > src/tests/mesos.hpp 6f4e0c5567b99891f6d0eceb7e6917d25083db0e > > > Diff: https://reviews.apache.org/r/66615/diff/1/ > > > Testing > ------- > > sudo make check (Fedora 27). > > > Thanks, > > James Peach > > --===============4274933653875002507==--