From reviews-return-76068-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Apr 12 16:41:22 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B6A16183A5 for ; Thu, 12 Apr 2018 16:41:22 +0000 (UTC) Received: (qmail 23258 invoked by uid 500); 12 Apr 2018 16:41:22 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 23228 invoked by uid 500); 12 Apr 2018 16:41:22 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 23213 invoked by uid 99); 12 Apr 2018 16:41:21 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Apr 2018 16:41:21 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 6A5E41A07EE; Thu, 12 Apr 2018 16:41:21 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.19 X-Spam-Level: * X-Spam-Status: No, score=1.19 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.25, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id IXNQml3A0e-a; Thu, 12 Apr 2018 16:41:20 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id CF3FC5F256; Thu, 12 Apr 2018 16:41:19 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 770A0E0117; Thu, 12 Apr 2018 16:41:19 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 4B344C404BB; Thu, 12 Apr 2018 16:41:19 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7972767678037672950==" MIME-Version: 1.0 Subject: Re: Review Request 61096: Building gRPC with CMake. From: Andrew Schwartzmeyer To: Benjamin Bannier , Jie Yu , Joseph Wu , Andrew Schwartzmeyer Cc: Chun-Hung Hsiao , mesos Date: Thu, 12 Apr 2018 16:41:19 -0000 Message-ID: <20180412164119.348.80579@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Andrew Schwartzmeyer X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/61096/ X-Sender: Andrew Schwartzmeyer References: <20180412032255.12092.81914@reviews-vm2.apache.org> In-Reply-To: <20180412032255.12092.81914@reviews-vm2.apache.org> Reply-To: Andrew Schwartzmeyer X-ReviewRequest-Repository: mesos --===============7972767678037672950== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61096/#review201007 ----------------------------------------------------------- I want to test on Windows and see if we can get it building there too before giving it a ship-it, but this looks good! 3rdparty/CMakeLists.txt Line 143 (original), 144-145 (patched) Seems reasonable. Could alternatively setup `ENABLE_GRPC` to set `ENABLE_SSL` (and therefore also `libevent`?) 3rdparty/CMakeLists.txt Lines 1012-1015 (patched) As stated above, the probably won't work on Windows yet. Ths VS solutions generally stick everything under `Debug` or `Release` folders, and it's done at build time, not configuration time. It's super annoying. 3rdparty/CMakeLists.txt Lines 1022-1027 (patched) Do you want the `C` or `CXX` flags forwarded too? - Andrew Schwartzmeyer On April 11, 2018, 8:22 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61096/ > ----------------------------------------------------------- > > (Updated April 11, 2018, 8:22 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and Joseph Wu. > > > Bugs: MESOS-7881 > https://issues.apache.org/jira/browse/MESOS-7881 > > > Repository: mesos > > > Description > ------- > > This patch adds an `ENABLE_GRPC` option and builds the bundled gRPC > 3rdparty library in CMake. > > > Diffs > ----- > > 3rdparty/CMakeLists.txt 488e906486a583e74faceb44d906cee5036a8b99 > 3rdparty/cmake/Versions.cmake 93f0322c1ac926bcfdcd4c1cfd9ba9f22bcf7099 > cmake/CompilationConfigure.cmake 3cb072ddcd286c0e40d44eaeba210ddf1796975c > src/cmake/MesosProtobuf.cmake dde034fe4d4251dd7c7397d422136bfa3c9c3ebc > > > Diff: https://reviews.apache.org/r/61096/diff/6/ > > > Testing > ------- > > `sudo make check` with CMake > > NOTE: Testing on Windowns is not done yet. > > > Thanks, > > Chun-Hung Hsiao > > --===============7972767678037672950==--