From reviews-return-75998-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Apr 11 19:02:20 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A554A1825D for ; Wed, 11 Apr 2018 19:02:20 +0000 (UTC) Received: (qmail 19545 invoked by uid 500); 11 Apr 2018 19:02:20 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 19509 invoked by uid 500); 11 Apr 2018 19:02:20 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 19490 invoked by uid 99); 11 Apr 2018 19:02:19 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Apr 2018 19:02:19 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 7155C1A0624; Wed, 11 Apr 2018 19:02:19 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.391 X-Spam-Level: ** X-Spam-Status: No, score=2.391 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_REPLYTO_END_DIGIT=0.25, HEADER_FROM_DIFFERENT_DOMAINS=0.25, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id pu5ZrA23RA_e; Wed, 11 Apr 2018 19:02:18 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 86F9C5FB2E; Wed, 11 Apr 2018 19:02:17 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C6CFFE010F; Wed, 11 Apr 2018 19:02:16 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 95466C404BB; Wed, 11 Apr 2018 19:02:16 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5931212622138832892==" MIME-Version: 1.0 Subject: Re: Review Request 66541: Added default executor test for agent recovery without metadata. From: Gilbert Song To: Jie Yu , Qian Zhang , Kevin Klues , Vinod Kone Cc: Mesos Reviewbot , Mesos Reviewbot Windows , Gilbert Song , mesos Date: Wed, 11 Apr 2018 19:02:16 -0000 Message-ID: <20180411190216.12093.85657@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Gilbert Song X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/66541/ X-Sender: Gilbert Song References: <20180410234157.29299.66424@reviews-vm2.apache.org> In-Reply-To: <20180410234157.29299.66424@reviews-vm2.apache.org> Reply-To: Gilbert Song X-ReviewRequest-Repository: mesos --===============5931212622138832892== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66541/ ----------------------------------------------------------- (Updated April 11, 2018, 12:02 p.m.) Review request for mesos, Jie Yu, Kevin Klues, Qian Zhang, and Vinod Kone. Bugs: MESOS-8416 https://issues.apache.org/jira/browse/MESOS-8416 Repository: mesos Description ------- Added default executor test for agent recovery without metadata. Diffs (updated) ----- src/tests/default_executor_tests.cpp 293dd20d882447401572835bd31e197faf76861b Diff: https://reviews.apache.org/r/66541/diff/2/ Changes: https://reviews.apache.org/r/66541/diff/1-2/ Testing ------- make check Verified that the test crashes without the fix in r/66539. Thanks, Gilbert Song --===============5931212622138832892==--