From reviews-return-75988-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Apr 11 18:31:09 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CA06718096 for ; Wed, 11 Apr 2018 18:31:09 +0000 (UTC) Received: (qmail 40883 invoked by uid 500); 11 Apr 2018 18:31:09 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 40850 invoked by uid 500); 11 Apr 2018 18:31:09 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 40835 invoked by uid 99); 11 Apr 2018 18:31:09 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Apr 2018 18:31:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 99583C0157; Wed, 11 Apr 2018 18:31:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.392 X-Spam-Level: ** X-Spam-Status: No, score=2.392 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_REPLYTO_END_DIGIT=0.25, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 3uL9FbqPiNYq; Wed, 11 Apr 2018 18:31:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id ABF455F3CC; Wed, 11 Apr 2018 18:31:05 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5AEC7E010F; Wed, 11 Apr 2018 18:31:05 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id D6692C404BB; Wed, 11 Apr 2018 18:31:04 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2116777488058404442==" MIME-Version: 1.0 Subject: Review Request 66559: Made agent flag '--hadoop_home' as optional. From: Gilbert Song To: Jie Yu , Qian Zhang Cc: Gilbert Song , mesos Date: Wed, 11 Apr 2018 18:31:04 -0000 Message-ID: <20180411183104.12092.95136@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Gilbert Song X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/66559/ X-Sender: Gilbert Song Reply-To: Gilbert Song X-ReviewRequest-Repository: mesos --===============2116777488058404442== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66559/ ----------------------------------------------------------- Review request for mesos, Jie Yu and Qian Zhang. Repository: mesos Description ------- Made agent flag '--hadoop_home' as optional. Diffs ----- docs/configuration/agent.md 962211a54177a54b3e38a93aad9af3c7a0f94ecb docs/operator-http-api.md 10dcac83fa70da5760a5c231665d7498cc168622 src/slave/containerizer/fetcher.cpp 7de57c21c55bc145a78d401bb4224322501c040b src/slave/flags.hpp beae47f0f8f2178b93a3484d168ce4d71c961841 src/slave/flags.cpp bdfc49a3903899b2741bb60c7e9e89f0196492e4 src/slave/http.cpp d500fde22d01d2c66104b72ff39d9de4e3a411cd Diff: https://reviews.apache.org/r/66559/diff/1/ Testing ------- make check Thanks, Gilbert Song --===============2116777488058404442==--