From reviews-return-75928-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Apr 10 20:47:55 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 567E918091 for ; Tue, 10 Apr 2018 20:47:55 +0000 (UTC) Received: (qmail 86148 invoked by uid 500); 10 Apr 2018 20:47:55 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 86117 invoked by uid 500); 10 Apr 2018 20:47:55 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 86102 invoked by uid 99); 10 Apr 2018 20:47:54 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Apr 2018 20:47:54 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 1B874C043B; Tue, 10 Apr 2018 20:47:54 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.941 X-Spam-Level: X-Spam-Status: No, score=0.941 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id L0mdQYB7Y3Dp; Tue, 10 Apr 2018 20:47:52 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 513585F1E7; Tue, 10 Apr 2018 20:47:52 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D9E67E0117; Tue, 10 Apr 2018 20:47:51 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id AC7B1C407A2; Tue, 10 Apr 2018 20:47:51 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5940502000884241866==" MIME-Version: 1.0 Subject: Re: Review Request 66460: Added a `call()` method to the v1 scheduler library. From: Gaston Kleiman To: Greg Mann , Vinod Kone Cc: Benjamin Mahler , Gaston Kleiman , mesos Date: Tue, 10 Apr 2018 20:47:51 -0000 Message-ID: <20180410204751.29300.61693@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Gaston Kleiman X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/66460/ X-Sender: Gaston Kleiman References: <20180410204516.29300.2297@reviews-vm2.apache.org> In-Reply-To: <20180410204516.29300.2297@reviews-vm2.apache.org> Reply-To: Gaston Kleiman X-ReviewRequest-Repository: mesos --===============5940502000884241866== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On April 10, 2018, 1:45 p.m., Benjamin Mahler wrote: > > include/mesos/v1/scheduler.hpp > > Lines 102-114 (patched) > > > > > > Hm.. why does this return an `Option`? > > > > If this is mesos Response rather than http::Response, aren't we losing information about which http code came back? (e.g. 400, 401, etc). If the request is not successful and the http code is neither 200 nor 202, the method will return an error that includes the http code and the body of the HTTP response. It returns a `scheduler::Response` in order to abstract the consumer from the transport layer and prevent it from having to understand and deserialize HTTP responses. - Gaston ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66460/#review200842 ----------------------------------------------------------- On April 6, 2018, 2:17 p.m., Gaston Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66460/ > ----------------------------------------------------------- > > (Updated April 6, 2018, 2:17 p.m.) > > > Review request for mesos, Greg Mann and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > This patch adds a `call()` method to the scheduler library that allows > clients to send a `v1::scheduler::Call` to the master and receive a > `v1::scheduler::Response`. > > It is going to be used to test operation state reconciliation. > > > Diffs > ----- > > include/mesos/v1/scheduler.hpp d56e08861d5190ef66992d383dc5710d8f6ce661 > src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp 60b17b9be74132c81532d22eba681feb899b22a3 > src/scheduler/scheduler.cpp ecef916ffd0797a13552525ff2cda0f99ca57e74 > > > Diff: https://reviews.apache.org/r/66460/diff/3/ > > > Testing > ------- > > `sudo bin/mesos-tests` on GNU/Linux > > > Thanks, > > Gaston Kleiman > > --===============5940502000884241866==--