From reviews-return-75645-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Apr 4 21:23:42 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 02B001895B for ; Wed, 4 Apr 2018 21:23:41 +0000 (UTC) Received: (qmail 45051 invoked by uid 500); 4 Apr 2018 21:23:40 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 45016 invoked by uid 500); 4 Apr 2018 21:23:40 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 45000 invoked by uid 99); 4 Apr 2018 21:23:40 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Apr 2018 21:23:40 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id B98D71A09BF; Wed, 4 Apr 2018 21:23:39 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.94 X-Spam-Level: X-Spam-Status: No, score=0.94 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id NZDrRfvSI6EL; Wed, 4 Apr 2018 21:23:38 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 7DB975F1F0; Wed, 4 Apr 2018 21:23:38 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 15B41E00CA; Wed, 4 Apr 2018 21:23:38 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 01341C409D6; Wed, 4 Apr 2018 21:23:38 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4170315164956398341==" MIME-Version: 1.0 Subject: Re: Review Request 66445: Windows: Cleaned up included CRT headers. From: John Kordich via Review Board To: Akash Gupta , Eric Mumau , John Kordich , Joseph Wu , Michael Park Cc: Andrew Schwartzmeyer , mesos Date: Wed, 04 Apr 2018 21:23:38 -0000 Message-ID: <20180404212338.35287.94994@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated In-Reply-To: <20180404192652.35287.24294@reviews-vm2.apache.org> X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/66445/ X-Sender: John Kordich X-ReviewBoard-ShipIt: 1 References: <20180404192652.35287.24294@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: 3rdparty/stout/include/stout/os/windows/open.hpp X-ReviewBoard-ShipIt-Only: 1 Reply-To: John Kordich X-ReviewRequest-Repository: mesos Sender: John Kordich --===============4170315164956398341== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66445/#review200498 ----------------------------------------------------------- Ship it! Ship It! - John Kordich On April 4, 2018, 7:26 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66445/ > ----------------------------------------------------------- > > (Updated April 4, 2018, 7:26 p.m.) > > > Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and Michael Park. > > > Bugs: MESOS-8759 > https://issues.apache.org/jira/browse/MESOS-8759 > > > Repository: mesos > > > Description > ------- > > The set `errno` value in `os::kill()` is never checked (especially on > Windows), so `_set_errno()` and thus `errno.h` were removed. > > The `fcntl.h` is used only to provide `O_CREAT` etc., and so belonged > in `open.hpp`, not `windows.hpp`. > > The remaining headers, `direct.h`, `io.h`, `process.h`, and `stdlib.h` > were no longer used or needed as the respective CRT APIs were > replaced. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/windows/kill.hpp 9cec1117fac3cf6bd624fc7db524ef1ad10cd55d > 3rdparty/stout/include/stout/os/windows/mkdtemp.hpp 9181429383a991fe2b87701d2bfd0e858ac2537b > 3rdparty/stout/include/stout/os/windows/open.hpp PRE-CREATION > 3rdparty/stout/include/stout/os/windows/rmdir.hpp a2926dab2c8e219cf5938c4df27f83488198dd6b > 3rdparty/stout/include/stout/os/windows/sendfile.hpp fff5872db6b3f69464e41e6d108a107e4eeabd12 > 3rdparty/stout/include/stout/windows.hpp 1bfcdf4a5c097cc6d2293396ce39c8ad2c9ec993 > 3rdparty/stout/include/stout/windows/dynamiclibrary.hpp 5b3cbf4f36ea9ac0411df52b4cfea8ef75fecbb5 > 3rdparty/stout/include/stout/windows/os.hpp 739ee4da3f09d2a9597d4451e755e77903e9287d > > > Diff: https://reviews.apache.org/r/66445/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > > --===============4170315164956398341==--