From reviews-return-75612-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Apr 4 17:29:36 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5160D18F35 for ; Wed, 4 Apr 2018 17:29:36 +0000 (UTC) Received: (qmail 49638 invoked by uid 500); 4 Apr 2018 17:29:36 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 49604 invoked by uid 500); 4 Apr 2018 17:29:36 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 49589 invoked by uid 99); 4 Apr 2018 17:29:35 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Apr 2018 17:29:35 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 18187C0047; Wed, 4 Apr 2018 17:29:35 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.691 X-Spam-Level: X-Spam-Status: No, score=0.691 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 4nAcl-stW4j4; Wed, 4 Apr 2018 17:29:34 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id E47265F1F0; Wed, 4 Apr 2018 17:29:33 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6FC1EE00CA; Wed, 4 Apr 2018 17:29:33 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 2155DC409D6; Wed, 4 Apr 2018 17:29:32 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1824766774341903229==" MIME-Version: 1.0 Subject: Re: Review Request 66441: Fixed mismatched types in `process.cpp`. From: Andrew Schwartzmeyer To: Akash Gupta , Eric Mumau , John Kordich , Joseph Wu , Michael Park Cc: Andrew Schwartzmeyer , mesos Date: Wed, 04 Apr 2018 17:29:32 -0000 Message-ID: <20180404172932.64153.46250@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Andrew Schwartzmeyer X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/66441/ X-Sender: Andrew Schwartzmeyer References: <20180404055709.21437.18845@reviews-vm2.apache.org> In-Reply-To: <20180404055709.21437.18845@reviews-vm2.apache.org> Reply-To: Andrew Schwartzmeyer X-ReviewRequest-Repository: mesos --===============1824766774341903229== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66441/#review200468 ----------------------------------------------------------- 3rdparty/libprocess/src/process.cpp Line 1387 (original), 1387 (patched) Oh I know why this is needed now, because `int_fd` is convertable to `int`, which I'm not thrilled out. I'll re-examine it... - Andrew Schwartzmeyer On April 3, 2018, 10:57 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66441/ > ----------------------------------------------------------- > > (Updated April 3, 2018, 10:57 p.m.) > > > Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and Michael Park. > > > Bugs: MESOS-8675 > https://issues.apache.org/jira/browse/MESOS-8675 > > > Repository: mesos > > > Description > ------- > > Because of the ternary, the primitive integer `-1` must be explicitly > constructed into an `int_fd` to match the type held in the `sockets` > container. > > > Diffs > ----- > > 3rdparty/libprocess/src/process.cpp 9eb37465cd86f408d69f5f98fb76c4f4b93b9acd > > > Diff: https://reviews.apache.org/r/66441/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > > --===============1824766774341903229==--